Allow stripping unclosed color tags #42549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
[C++]
|
Would be great to have a unit test for this :). |
ZhilkinSerg
force-pushed
the
allow-stripping-unclosed-color-tags
branch
from
75bf82d to
8914fa5
Compare
ZhilkinSerg
added
the
Code: Tests
ZhilkinSerg
force-pushed
the
allow-stripping-unclosed-color-tags
branch
2 times, most recently
from
bfcba3d to
b9c0855
Compare
ZhilkinSerg
force-pushed
the
allow-stripping-unclosed-color-tags
branch
from
b9c0855 to
1e03784
Compare
ZhilkinSerg
commented
Jul 30, 2020
feinorgh
pushed a commit
to feinorgh/Cataclysm-DDA
that referenced
this pull request
Aug 1, 2020
* Allow stripping unclosed color tags * Added tests for remove_color_tags function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: NonePurpose of change
Strings with with single
<color_X>tag would not be processed and returned as-is byremove_color_tagsfunction.Describe the solution
Allow stripping a single
<color_X>tag from the string.Testing
<color_X>tag does not trigger debug message.Additional context
#42543