Precompiled header fallout #42544
Merged
Precompiled header fallout #42544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using precompiled headers, the suppression of this warning isn't working correctly. We could suppress it in other ways, but this seems simpler.
There was a false-positive for header guard check in a cpp file. Fix it by not looking for bad guards in non-headers.
anothersimulacrum
added
the
Code: Build
|
#42535 is probably a better fix than the adding of a virtual destructor here. |
Coolthulhu
referenced
this pull request
in cataclysmbnteam/Cataclysm-BN
May 25, 2021
* Add a virtual destructor to a Catch2 struct When using precompiled headers, the suppression of this warning isn't working correctly. We could suppress it in other ways, but this seems simpler. * Don't try to fix header guards in non-headers There was a false-positive for header guard check in a cpp file. Fix it by not looking for bad guards in non-headers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
To fix some CI issues resulting from the precompiled header PR.
Describe the solution
catch.hppto avoid a warning there.Describe alternatives you've considered
Suppressing the compiler warning in other ways.
Testing
Don't have the means to properly test locally right now; hoping the CI tests it sufficiently.
Additional context