Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colored Font that fixes the colored issue #42378

Merged
merged 5 commits into from
Jul 22, 2020
Merged

Colored Font that fixes the colored issue #42378

merged 5 commits into from
Jul 22, 2020

Conversation

Maryionet
Copy link
Contributor

@Maryionet Maryionet commented Jul 22, 2020

Summary

SUMMARY: None

Purpose of change

I added it soo that a non windows player can see a range of colors instead of all white.

Describe the solution

what it does is it just colors the terrain buildings etc that are previously all white except roads forest trails and few things i achieved this by painting the png's "glyphs" and "letters".

Describe alternatives you've considered

I tried editing symbols of the mod also tried changing the colors in the color manager and in the json but it failed to fix the issue.

Testing

i repeatedly open and close the game to see if it stable and soo far no crashes but since it's just a colored font there are no color variety in buildings terrain but since the alternative is just all white i think this solution is good.

Additional context

Screenshot_20200722-165652_Cataclysm DDA

@Qrox
Copy link
Contributor

Qrox commented Jul 22, 2020

Won't this cause problems with color blending on Windows?

Edit: Ok now I see you're just adding a new file so that's probably fine. But if the symbols are not colored on Android there must be something wrong with the renderer that needs fixing.

@Maryionet
Copy link
Contributor Author

Won't this cause problems with color blending on Windows?

Maybe but this colored version is meant to be for non windows users like android and mac etc

@Maryionet
Copy link
Contributor Author

Won't this cause problems with color blending on Windows?

Edit: Ok now I see you're just adding a new file so that's probably fine. But if the symbols are not colored on Android there must be something wrong with the renderer that needs fixing.

Yep most likely

@anothersimulacrum anothersimulacrum added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding labels Jul 22, 2020
@ZhilkinSerg ZhilkinSerg merged commit 8b3ab8b into CleverRaven:master Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants