Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consume fixes #40508

Merged
merged 3 commits into from
May 13, 2020
Merged

Consume fixes #40508

merged 3 commits into from
May 13, 2020

Conversation

Ramza13
Copy link
Contributor

@Ramza13 Ramza13 commented May 13, 2020

Summary

SUMMARY: Bugfixes "Fix bugs in the consume code."

Purpose of change

Fixes #40505
Fixes #40506
Fixed a divide by zero error and added sensible default case handling/removed debugmsg.

Describe the solution

Describe alternatives you've considered

Testing

Additional context

src/consumption.cpp Outdated Show resolved Hide resolved
@Night-Pryanik
Copy link
Contributor

Please properly fill the Summary section of the OP.

@kevingranade kevingranade merged commit 3ac02c5 into CleverRaven:master May 13, 2020
@DillonSimeone
Copy link
Contributor

DillonSimeone commented May 13, 2020

Bad news, #40506 is still occurring. #40505 appears to be fixed, though!

@Ramza13 Ramza13 deleted the consume_fix branch May 13, 2020 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants