Directional Vehicle Parts for mounted tools, seats, windshields, rams, and doors

[mrkybe]

Summary

SUMMARY: Infrastructure "Adds a script for creating directional vehicle parts from json."

Purpose of change

A step towards making this a reality #35861

I applied the script to most vehicle parts: seats, rams, doors, tools, windshields. Game will now ask you which variant you want to mount of that piece, like it does for frames.

Describe the solution

Edit the script to set the parts.json to be modified. Possibly comment out some of the variants you don't want included. The script takes every non-abstract part in parts.json and makes it an abstract one. Then it creates a variant for each of those similar to the ones that exist for frames/boards. For convenience it also writes a textfile with every newly created id, hopefully that can help tileset makers update their tilesets?

[lgtm-com]

This pull request introduces 1 alert when merging d2ca094 into f6d85ac - view on LGTM.com

new alerts:

• 1 for Unused import

[ifreund]

This is only going to work on windows

[mrkybe]

The script I based this off, this https://github.com/CleverRaven/Cataclysm-DDA/blob/master/tools/json_tools/pocket_mags.py and it wasn't working for me on Windows. I don't actually expect anyone to be running this script, as I'm committing the transformed JSON along side it. It's more for documentation purposes.

[lgtm-com]

This pull request introduces 1 alert when merging 8d3170c into 2abca8f - view on LGTM.com

new alerts:

• 1 for Unused import

[kevingranade]

Unfortunately, any part that's been converted to abstract doesn't exist anymore. So vehicle definitions that were using that part will have an error instead.

If I understand you correctly, this is not ok, it's going to impose a huge rewrite and migration effort that is going to have to be adressed immediately.

Can you instead have it introduce a new abstract part and then create a non-abstrsct post that inherits from it and uses the original name?

I.e. some part "heavy_frame"
The script moves the contents of "heavy_frame" to "heavy_frame_abstract" and also creates a "heavy_frame" that is a shallow copy of "heavy_frame_abstract".

With that done everything can be migrated over piecemeal.

[mrkybe]

Can you instead have it introduce a new abstract part and then create a non-abstrsct post that inherits from it and uses the original name?

I.e. some part "heavy_frame"
The script moves the contents of "heavy_frame" to "heavy_frame_abstract" and also creates a "heavy_frame" that is a shallow copy of "heavy_frame_abstract".

With that done everything can be migrated over piecemeal.

Perfect, that's a lot easier than my plan of writing a script to update the vehicle definitions. I'll do that.

[I-am-Erk]

How's it going with this?

[mrkybe]

How's it going with this?

This is ready.

[I-am-Erk]

🎶Did I ever tell you you're my hero?

🎶You're everything I would like to beeeeee

🎶I can fly higher than an eeeagle

🎶Can you help me script changes to the default json vehicles now so they use directional paaarts pleeeeeease