Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flu vaccine lasts 6 months instead of forever #40287

Merged
merged 2 commits into from
May 7, 2020

Conversation

wapcaplet
Copy link
Contributor

@wapcaplet wapcaplet commented May 7, 2020

Summary

SUMMARY: Bugfixes "Flu vaccine lasts 6 months instead of forever"

Purpose of change

To make the flu vaccine in game have a realistic effect length (6 months, rather than forever).

Describe the solution

Change the flu_vaccine function to use a 6-month duration, and not use a permanent effect.

Describe alternatives you've considered

The real flu vaccine doesn't guarantee immunity, but I'm not sure how to model that. Giving it a non-infinite duration seemed like a good compromise.

Testing

In-game, to ensure the duration and permanence did what I expected:

  • Tested a 10-minute vaccine, non-permanent, checked that it wore off in 10 minutes
  • Tested a 10-minute vaccine, permanent, checked that it did not wear off in 10 minutes

Additional context

The 30-day duration was added in #33243 but the "permanent" flag predates it. 30 days much too short for a realistic flu shot effect anyway:

The effects of the vaccine generally only last through one flu season,
which is about six months long.
https://www.verywellhealth.com/how-long-does-a-flu-shot-last-770538

How long does immunity from influenza vaccine last?
Protection from influenza vaccine is thought to persist for at least 6 months.
https://www.immunize.org/askexperts/experts_inf.asp

All right, how long does the flu shot last?
The short answer: six months. But the long answer is a little bit more complicated
https://www.health.com/condition/cold-flu-sinus/how-long-does-the-flu-shot-last

The add_effect method's fourth argument "permanent" was set to true,
making the flu shot last forever, despite the 30_days duration. This
commit removes the permanent flag, and changes duration to 6 months.
src/iuse.cpp Outdated Show resolved Hide resolved
Co-authored-by: Jason Jones <jasonedwardjones@gmail.com>
@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) Mechanics: Effects / Skills / Stats Effects / Skills / Stats labels May 7, 2020
@ZhilkinSerg ZhilkinSerg merged commit 24cc471 into CleverRaven:master May 7, 2020
@wapcaplet wapcaplet deleted the fix-forever-flu-shot branch May 7, 2020 21:14
@eJ0opb eJ0opb mentioned this pull request May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) Mechanics: Effects / Skills / Stats Effects / Skills / Stats
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants