Allow specifying clang version in makefile again #39923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts the CLANG specific checks added in 9eb2ff5, because they would break if a specific CLANG version was specified instead of a generic one. I hope to be able to make it so that you don't use CLANG even if your make command has CLANG=0, but as these changes are they break things, so I'll revert them and work on that later.
This was referenced May 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
This reverts the CLANG specific checks added in 9eb2ff5, because they would break if a specific CLANG version was specified instead of a generic one.
Testing
Game builds with clang.
Additional context
I hope to be able to make it so that you don't use CLANG even if your make command has CLANG=0, but as these changes are they break things, so I'll revert them and work on that later.