Replace non-iterator, non-lambda auto with proper type

[anothersimulacrum]

Summary

SUMMARY: None

Purpose of change

Use proper type in place of auto

Testing

Game & tests compile and run.

Additional context

Some range based loops over std::vector<item *> were using const auto &it, where it is (obviously) of type item *.
When converting these to the proper type, they were changed to item *it, because it's both not a reference and it was being modified in the loop.
Not sure what's up with it working with auto.

[jbytheway]

Not sure what's up with it working with auto.

You can have a reference to a pointer; that's what it was doing. Of course, this also relies on the "magic" lifetime-extension of temporaries captured by reference, which is potentially confusing.

Regardless, changes are good :).

[anothersimulacrum]

I'd say that, but it also didn't work when it was const item &*it.

src/activity_handlers.cpp: In function ‘void activity_handlers::forage_finish(player_activity*, player*)’:
src/activity_handlers.cpp:1767:27: error: cannot declare pointer to ‘const class item&’
 1767 |         for( const item &*it : dropped ) {
      |                           ^~
src/activity_handlers.cpp:1771:50: error: passing ‘const item’ as ‘this’ argument discards qualifiers [-fpermissive]
 1771 |                 it->set_flag( flag_HIDDEN_POISON );
      |                                                  ^
In file included from src/inventory.h:19,
                 from src/character.h:32,
                 from src/avatar.h:11,
                 from src/activity_handlers.cpp:19:
src/item.h:1391:15: note:   in call to ‘item& item::set_flag(const string&)’
 1391 |         item &set_flag( const std::string &flag );
      |               ^~~~~~~~
src/activity_handlers.cpp:1772:28: error: assignment of member ‘item::poison’ in read-only object
 1772 |                 it->poison = rng( 2, 7 );
      |                 ~~~~~~~~~~~^~~~~~~~~~~~~
src/activity_handlers.cpp:1775:49: error: passing ‘const item’ as ‘this’ argument discards qualifiers [-fpermissive]
 1775 |                 it->set_flag( flag_HIDDEN_HALLU );
      |                                                 ^
In file included from src/inventory.h:19,
                 from src/character.h:32,
                 from src/avatar.h:11,
                 from src/activity_handlers.cpp:19:
src/item.h:1391:15: note:   in call to ‘item& item::set_flag(const string&)’
 1391 |         item &set_flag( const std::string &flag );
      |  

Just const item *it:

src/activity_handlers.cpp: In function ‘void activity_handlers::forage_finish(player_activity*, player*)’:
src/activity_handlers.cpp:1771:50: error: passing ‘const item’ as ‘this’ argument discards qualifiers [-fpermissive]
 1771 |                 it->set_flag( flag_HIDDEN_POISON );
      |                                                  ^
In file included from src/inventory.h:19,
                 from src/character.h:32,
                 from src/avatar.h:11,
                 from src/activity_handlers.cpp:19:
src/item.h:1391:15: note:   in call to ‘item& item::set_flag(const string&)’
 1391 |         item &set_flag( const std::string &flag );
      |               ^~~~~~~~
src/activity_handlers.cpp:1772:28: error: assignment of member ‘item::poison’ in read-only object
 1772 |                 it->poison = rng( 2, 7 );
      |                 ~~~~~~~~~~~^~~~~~~~~~~~~
src/activity_handlers.cpp:1775:49: error: passing ‘const item’ as ‘this’ argument discards qualifiers [-fpermissive]
 1775 |                 it->set_flag( flag_HIDDEN_HALLU );
      |                                                 ^
In file included from src/inventory.h:19,
                 from src/character.h:32,
                 from src/avatar.h:11,
                 from src/activity_handlers.cpp:19:
src/item.h:1391:15: note:   in call to ‘item& item::set_flag(const string&)’
 1391 |         item &set_flag( const std::string &flag );
      |   

[Qrox]

It should be const item *&, i.e. a reference to a pointer. const item &* means a pointer to a reference, which doesn't exist in c++.

[anothersimulacrum]

Ah, whoops!
Though, that doesn't work either

src/activity_handlers.cpp: In function ‘void activity_handlers::forage_finish(player_activity*, player*)’:
src/activity_handlers.cpp:1767:32: error: cannot bind non-const lvalue reference of type ‘const item*&’ to an rvalue of type ‘const item*’
 1767 |         for( const item *&it : dropped ) {
      |                                ^~~~~~~
src/activity_handlers.cpp:1771:50: error: passing ‘const item’ as ‘this’ argument discards qualifiers [-fpermissive]
 1771 |                 it->set_flag( flag_HIDDEN_POISON );
      |                                                  ^
In file included from src/inventory.h:19,
                 from src/character.h:32,
                 from src/avatar.h:11,
                 from src/activity_handlers.cpp:19:
src/item.h:1391:15: note:   in call to ‘item& item::set_flag(const string&)’
 1391 |         item &set_flag( const std::string &flag );
      |               ^~~~~~~~
src/activity_handlers.cpp:1772:28: error: assignment of member ‘item::poison’ in read-only object
 1772 |                 it->poison = rng( 2, 7 );
      |                 ~~~~~~~~~~~^~~~~~~~~~~~~
src/activity_handlers.cpp:1775:49: error: passing ‘const item’ as ‘this’ argument discards qualifiers [-fpermissive]
 1775 |                 it->set_flag( flag_HIDDEN_HALLU );
      |                                                 ^
In file included from src/inventory.h:19,
                 from src/character.h:32,
                 from src/avatar.h:11,
                 from src/activity_handlers.cpp:19:
src/item.h:1391:15: note:   in call to ‘item& item::set_flag(const string&)’
 1391 |         item &set_flag( const std::string &flag );
      |               ^~~~~~~~

[Qrox]

I see, the const modifier in const auto was actually modifying the pointer, not the type, so it should probably be item *const &, i.e. a reference to a const pointer to a (non-const) item.