Migrate panel manager to ui_adaptor #39758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
[C++]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Interface "Migrate panel manager to ui_adaptor"
Purpose of change
Migrate more UIs to ui_adaptor. Fixes #39663.
Describe the solution
Renamed
panel_manager::draw_admtopanel_manager::show_admand moved the call to it fromgame::draw_panelstogame::handle_action. Got rid of some tail-recursive calls togame::draw_panelsin the process.panel_manager::show_admandgame::draw_panelsno longer needs thecolumnandindexparameters so these are removed.Then I refactored
panel_manager::show_admto clarify the variable names, and fixed an issue of duplicate selected entry when swapping panels.Finally, migrated the UI to
ui_adaptor.Testing
Tested on both tiles and curses.
Switched off all panels, exited the panel manager, and the game did not crash (fixes #39663)
Opened sub-UIs and resized the game window, and the UI was resized and redrawn correctly.