Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows survivors to cook tea using lotus and spurge flowers #39727

Merged
merged 5 commits into from
Apr 23, 2020

Conversation

HarrisonGreenlee
Copy link
Contributor

@HarrisonGreenlee HarrisonGreenlee commented Apr 19, 2020

Summary

SUMMARY: Content "Adds lotus and spurge flower teas to the game. Spurge tea prevents asthma attacks."

Purpose of change

Provide utility for flowers that are otherwise useless.

Describe the solution

Allow players to brew tea and drink tea using lotus and spurge flowers.

According to this study, spurge flowers have anti-asthmatic properties. Because of this, the spurge tea has a special effect - it is able to prevent asthma attacks. However, it is not able to stop an asthma attack if it is already happening.

Describe alternatives you've considered

I considered not giving spurge tea anti-asthmatic effects because I was worried that these properties were not verified by a clinical trial. Fortunately, I was able to find a study that verifies that the anti-asthmatic properties of spurge flowers (see above). However, I wanted to make sure that this study was correct so I checked it against a couple other studies: [1] [2]

Because of these studies I feel that it is safe to give spurge tea anti-asthmatic properties.

Testing

  • Compiled the game without any errors.
  • Collected flowers to make sure they are a valid drop.
  • Crafted tea to make sure the JSON recipes are functional.
  • Examined and consumed tea to ensure that there are no errors.
  • Debugged asthma onto my character to make sure that spurge tea cannot remove the asthma status effect caused by an asthma attack. Spurge tea prevents asthma attacks, it can't cure them.
  • Waited to have an asthma attack after drinking spurge tea, but never had one. However, it's possible that I just got lucky. I am not sure how I would test this to guarantee that spurge tea prevents asthma attacks.

Additional context

N/A

@Rivet-the-Zombie Rivet-the-Zombie merged commit cd96ae3 into CleverRaven:master Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants