-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds new arsonist quest and unlocks her as a merchant after completion. #39688
Merged
ZhilkinSerg
merged 9 commits into
CleverRaven:master
from
Brian-Otten:Arsonist-explosives-quest
Apr 20, 2020
Merged
Adds new arsonist quest and unlocks her as a merchant after completion. #39688
ZhilkinSerg
merged 9 commits into
CleverRaven:master
from
Brian-Otten:Arsonist-explosives-quest
Apr 20, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
data/json/npcs/refugee_center/surface_visitors/NPC_arsonist.json
Outdated
Show resolved
Hide resolved
data/json/npcs/refugee_center/surface_visitors/NPC_arsonist.json
Outdated
Show resolved
Hide resolved
data/json/npcs/refugee_center/surface_visitors/NPC_arsonist.json
Outdated
Show resolved
Hide resolved
data/json/npcs/refugee_center/surface_visitors/NPC_arsonist.json
Outdated
Show resolved
Hide resolved
data/json/npcs/refugee_center/surface_visitors/NPC_arsonist.json
Outdated
Show resolved
Hide resolved
Co-Authored-By: Anton Burmistrov <Night_Pryanik@mail.ru>
Co-Authored-By: Anton Burmistrov <Night_Pryanik@mail.ru>
Co-Authored-By: Anton Burmistrov <Night_Pryanik@mail.ru>
Co-Authored-By: Anton Burmistrov <Night_Pryanik@mail.ru>
Co-Authored-By: Anton Burmistrov <Night_Pryanik@mail.ru>
Thanks for the second pair of eyes, changes committed. |
…Otten/Cataclysm-DDA into Arsonist-explosives-quest
Could you please also add rebar to the arsonist stocks? Probably nails too, since you get those in great quantities from burning down buildings. |
Added rebar and nails and checked they were working properly. good idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Content "Adds new quest and stock to the arsonist"
Purpose of change
The arsonist currently says she will sell you some molotovs but doesn't really, and she is flagged as a potential quest giver in the json files.
Describe the solution
The arsonist now has a quest for the player to bring her 2 bags of commercial fertilizer so she can expand her arsenal with bombs rather than just molotovs. If you complete the quest, she will give you 10 molotovs as a reward, and also become available as a trader.
She has a stock of explosives (molotovs and pipebombs), some fuses, and a chance to sell the anarchist book or some spare commercial fertilizer.
Testing
Load up the game.
Do the quest successfully, wandering through all the dialog options to check for bugs.
Check that trade was only unlocked after quest completion.
Trade with npc.
Additional context
The way the game loads stock for merchants seems to be a bit of a mess right now so the stock available on this (and all other merchants) is quite random. I hope to circle around and try to tackle that in depth later.