Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new arsonist quest and unlocks her as a merchant after completion. #39688

Merged
merged 9 commits into from
Apr 20, 2020

Conversation

Brian-Otten
Copy link
Contributor

Summary

SUMMARY: Content "Adds new quest and stock to the arsonist"

Purpose of change

The arsonist currently says she will sell you some molotovs but doesn't really, and she is flagged as a potential quest giver in the json files.

Describe the solution

The arsonist now has a quest for the player to bring her 2 bags of commercial fertilizer so she can expand her arsenal with bombs rather than just molotovs. If you complete the quest, she will give you 10 molotovs as a reward, and also become available as a trader.
She has a stock of explosives (molotovs and pipebombs), some fuses, and a chance to sell the anarchist book or some spare commercial fertilizer.

Testing

Load up the game.
Do the quest successfully, wandering through all the dialog options to check for bugs.
Check that trade was only unlocked after quest completion.
Trade with npc.

Additional context

The way the game loads stock for merchants seems to be a bit of a mess right now so the stock available on this (and all other merchants) is quite random. I hope to circle around and try to tackle that in depth later.

image

@Brian-Otten Brian-Otten requested a review from I-am-Erk as a code owner April 18, 2020 15:34
Brian-Otten and others added 5 commits April 18, 2020 18:16
Co-Authored-By: Anton Burmistrov <Night_Pryanik@mail.ru>
Co-Authored-By: Anton Burmistrov <Night_Pryanik@mail.ru>
Co-Authored-By: Anton Burmistrov <Night_Pryanik@mail.ru>
Co-Authored-By: Anton Burmistrov <Night_Pryanik@mail.ru>
Co-Authored-By: Anton Burmistrov <Night_Pryanik@mail.ru>
@Brian-Otten
Copy link
Contributor Author

Thanks for the second pair of eyes, changes committed.

@mlangsdorf mlangsdorf added [JSON] Changes (can be) made in JSON NPC / Factions NPCs, AI, Speech, Factions, Ownership labels Apr 18, 2020
@AlexMooney
Copy link
Contributor

Could you please also add rebar to the arsonist stocks? Probably nails too, since you get those in great quantities from burning down buildings.

@Brian-Otten
Copy link
Contributor Author

Added rebar and nails and checked they were working properly. good idea.

@ZhilkinSerg ZhilkinSerg merged commit 28e603d into CleverRaven:master Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants