Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct grammar for healing messages #39687

Merged
merged 1 commit into from
Apr 19, 2020

Conversation

wapcaplet
Copy link
Contributor

Summary

SUMMARY: Bugfixes "Use correct grammar for healing messages"

Purpose of change

Fixes #39675

Describe the solution

Removes the unnecessary word "was" from these messages, displayed when a bandaged or disinfected wound on some body part becomes fully healed:

  • Bandaged wounds on your __ healed.
  • Disinfected wounds on your __ healed.

Describe alternatives you've considered

Considered alternative phrasing, including:

  • Bandaged/disinfected wounds on your __ were healed.
  • Bandaged/disinfected wounds on your __ have healed.

But in both cases the extra word is not only unnecessary, but suggests that the healing occurred some time ago (rather than just as the message is printed, which is the intended meaning).

Testing

Debug self-injury, used bandages and antiseptic. Correct messages were shown.

Additional context

image

@kevingranade kevingranade merged commit 75cf69a into CleverRaven:master Apr 19, 2020
@wapcaplet wapcaplet deleted the wounded-grammar branch April 24, 2020 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grammar of Healing Notifications
2 participants