Blazemod Mini-PR: Change copy-from for turrets #39664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soup-de-Loop
changed the title
Soup-de-Loop
force-pushed
the
soupdeloop-blazemod-PR2
branch
2 times, most recently
from
5f46799 to
1372b12
Compare
|
Put into draft format so that it can be rebased off of the master repo once #39659 is committed, so that the change comparison is a lot neater. |
ZhilkinSerg
added
[JSON]
Soup-de-Loop
force-pushed
the
soupdeloop-blazemod-PR2
branch
from
1372b12 to
3dadb63
Compare
|
Rebase force pushed now that dependency PR #39659 has been committed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Mods "Changes all blazemod turrets to use vanilla turrets"Purpose of change
This is the second PR in bringing the changes in #37497 about, by breaking each change into small parts that are easier to skim and understand.
Describe the solution
Changes all
copy-fromfields from using"turret_blaze"or"turret_manual_blaze"to using only"turret", paving the way for removal of the redundantturretframefrom blazemod.Testing
Straightforward changes drawn from #37497, probably might work for now but its compatibility will be broken again when ID's are changed.
Additional context
More PR's to come, consider incomplete by itself, part of a whole.