Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused header from HeaderGuardCheck.cpp #39587

Merged
merged 1 commit into from
Apr 15, 2020
Merged

Remove unused header from HeaderGuardCheck.cpp #39587

merged 1 commit into from
Apr 15, 2020

Conversation

Qrox
Copy link
Contributor

@Qrox Qrox commented Apr 15, 2020

Summary

SUMMARY: None

Purpose of change

Including "platform_win.h" is causing compilation errors and it seems that it's not actually needed.

Describe the solution

Remove the include.

Testing

It compiles.

@jbytheway
Copy link
Contributor

Strange, I don't know how that ended up in there. Thanks for tidying up.

@jbytheway
Copy link
Contributor

Strange, I don't know how that ended up in there. Thanks for tidying up.

Now I remember; I thought it was needed for stat. But if you say it's not, then that's even better.

@ZhilkinSerg ZhilkinSerg added the [C++] Changes (can be) made in C++. Previously named `Code` label Apr 15, 2020
@ZhilkinSerg ZhilkinSerg merged commit 9d5f55d into CleverRaven:master Apr 15, 2020
@Qrox Qrox deleted the remove-unused-header branch April 17, 2020 06:54
@weekly-digest weekly-digest bot mentioned this pull request Apr 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
[C++] Changes (can be) made in C++. Previously named `Code`
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Qrox @jbytheway @ZhilkinSerg