Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bearings recipe metal requirements #39583

Merged
merged 2 commits into from
Apr 15, 2020
Merged

Conversation

Hirmuolio
Copy link
Contributor

@Hirmuolio Hirmuolio commented Apr 15, 2020

Summary

SUMMARY: Bugfixes "Fix bearing requiring both "weight" and "steel""

Purpose of change

Crafting bearings requires both weight (lead/gold/silver...) and steel. So the bearings were always made of steel and some other random metal.

Lead bearings definitely should be possible for ammo use. Bearings from other metals make sense too as lead replacement.

You should be able to make the bearings from one metal only.

The amount of metal required was also wildly inaccurate. Crafting 0.50 kg of bearings required 6 kg of steel and 0.15 kg of other metal.

Describe the solution

Moved "steel_standard" from using to component.

Changed the material numbers so that it now requires 0.50 kg of steel or 0.51 kg of other metals.

Describe alternatives you've considered

If there are uses that assume hard steel bearings then the softer metal barings for ammo use could be split to separate item.

Testing

Recipe works.

Additional context

Before:
before

After:
after2

@Hirmuolio Hirmuolio changed the title bearings bearings recipe metal requirements Apr 15, 2020
@Brian-Otten
Copy link
Contributor

You changed the amount of material going into the bearing (steel or gold VS steel and gold) without changing the amount of bearings produced. you should probably audit the recipe so there is an attempt at conservation of mass and see what the correct amount of bearings would be.

@Hirmuolio
Copy link
Contributor Author

Hirmuolio commented Apr 15, 2020

Yeah the weights seem to be all over the place.
Those steel parts weight 6 kg while the other metal parts weight 0.15 kg.
The resulting stack of bearings weights 0.5 kg.

@Mecares
Copy link
Contributor

Mecares commented Apr 15, 2020

Are bearings used in any crafting recipes or only as ammo? Because bearings made from lead sound like a terrible idea if used as actual bearings to me. Maybe make them uncraftable and instead use the crafting recipe to craft a similar item called sling bullets?

@Hirmuolio
Copy link
Contributor Author

I am not seeing it used in any recipes other than soime shot recipes.
It is in some uncraft recipes. But that just means you get bearings from those items. Nobody has implemented recipes for player crafting those items yet.

@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling labels Apr 15, 2020
@ZhilkinSerg ZhilkinSerg merged commit d17305e into CleverRaven:master Apr 15, 2020
@Hirmuolio Hirmuolio deleted the bearing branch April 16, 2020 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants