Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust height/bodyweight tests for varying height #39514

Merged
merged 1 commit into from
Apr 19, 2020

Conversation

wapcaplet
Copy link
Contributor

Summary

SUMMARY: Infrastructure "Adjust height/bodyweight tests for varying height"

Purpose of change

To make the height/bodyweight biometrics tests more accurate with the new adjustable height, and to exercise some aspect of the relative height-adjustment done in Character::height()

Describe the solution

Changes tests/char_biometrics_test.cpp to account for variable height, and does some tests with different initial heights to ensure that various size mutations (SMALL, LARGE, HUGE) are reflected in the adjusted relative height() return value.

Describe alternatives you've considered

Oblivion

Testing

tests/cata_test [biometrics] --order rand

Additional context

Supports #39385

@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing. labels Apr 13, 2020
@wapcaplet
Copy link
Contributor Author

wapcaplet commented Apr 14, 2020

Some CI failures are from the elite bio-operator issue fixed by #39516 . Not sure what Travis's problem is; says all tests are passing, yet it reports as failed.

@anothersimulacrum
Copy link
Member

The issue with travis has since been fixed.
https://travis-ci.org/github/CleverRaven/Cataclysm-DDA/jobs/674215555#L4786

@wapcaplet wapcaplet force-pushed the adjustable-height-tests branch from ea7e4aa to f1eb80f Compare April 18, 2020 02:03
@wapcaplet
Copy link
Contributor Author

AppVeyor now has a failure with ranged balance tests, no idea how they could be related to this PR:

C:\Projects\Cataclysm-DDA\tests\ranged_balance_test.cpp(235): FAILED:
  CHECK( fast_stats.avg() > hit_rate )
with expansion:
  0.287037037 > 0.45f

@kevingranade kevingranade merged commit 6ea5c65 into CleverRaven:master Apr 19, 2020
@wapcaplet wapcaplet deleted the adjustable-height-tests branch April 25, 2020 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants