Don't perform translations at initialization #39494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix clang-tidy warnings about translations being performed in static initialization of objects, by converting the relevant strings into translation objects.
jbytheway
force-pushed
the
fix_static_translations
branch
from
320d949 to
24c7ff0
Compare
Now this array order dictates GUI order, it should be in a more logical order.
jbytheway
force-pushed
the
fix_static_translations
branch
from
24c7ff0 to
e9fd1e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Details
Fix clang-tidy warnings about translations being performed in static initialization of objects, by converting the relevant strings into translation objects.
Testing
Unit tests and looking at the GUI in-game.