Helicopter bugfixes : allow descending into open air while moving, and disallow roof teleporting #39275
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "allow descending into open air while moving, and disallow roof teleporting"
Purpose of change
Helicopters had no check for a roof when ascending, this fixes that.
They also didn tallow descending while moving - this was to ensure that landings were safe.
But this shouldnt be the case if its just pure open air below them, so ive done that check too.
Describe the solution
As above.
Describe alternatives you've considered
N/A
Testing
Spawned a helicopter inside a church, and tried to take off, couldnt.
Flew a helicopter at z-level 5, tried to descend to z-level 4 while flying fast, could.
Additional context
N/A