Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helicopter bugfixes : allow descending into open air while moving, and disallow roof teleporting #39275

Merged
merged 2 commits into from Apr 6, 2020

Conversation

ghost
Copy link

@ghost ghost commented Apr 5, 2020

Summary

SUMMARY: Bugfixes "allow descending into open air while moving, and disallow roof teleporting"

Purpose of change

Helicopters had no check for a roof when ascending, this fixes that.
They also didn tallow descending while moving - this was to ensure that landings were safe.
But this shouldnt be the case if its just pure open air below them, so ive done that check too.

Describe the solution

As above.

Describe alternatives you've considered

N/A

Testing

Spawned a helicopter inside a church, and tried to take off, couldnt.

Flew a helicopter at z-level 5, tried to descend to z-level 4 while flying fast, could.

Additional context

N/A

@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Vehicles Vehicles, parts, mechanics & interactions Z-levels Levels below and above ground. labels Apr 6, 2020
@ZhilkinSerg ZhilkinSerg merged commit c6989fc into CleverRaven:master Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Vehicles Vehicles, parts, mechanics & interactions Z-levels Levels below and above ground.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant