Re-audit Kel-Tec pistol volumes, add magwell volumes #39141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
ghost
changed the title
ghost
changed the title
ghost
changed the title
ghost
deleted the
twadams
pushed a commit
to twadams/Cataclysm-DDA
that referenced
this pull request
Apr 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Re-audit Kel Tec pistols & magazines"Purpose of change
Closes #39137, helps #37374. Each gun was missing
magazine_well, making all mags completely external. Tenmillimaster told me the mags & pistols need to be redone as they weren't done with ImageJ back when they were added.Describe the solution
Add
magazine_wellto all three pistols equal to their respective magazines. Auditing mags & guns using ImageJ.Describe alternatives you've considered
Destroying Kel-Tec for giving angled magazine views, but flat gun views. 😡
Testing
Debugged in all three pistols after giving magazine_well definition to only P32, volume changed according to each gun's magazine minus magazine well volume. Added other two well volumes to confirm overwriting.
Additional context
Kel-Tec PF9, overall length 14.9cm and width 2.2cm: https://www.keltecweapons.com/firearms/pistols/pf9/
Surface area: https://imgur.com/a/jY6UY6U
Using line from floorplate of magazine for mag measurement: https://imgur.com/a/fmdDUbC
Flat view of magazine(KelTec's own picture is canted): https://gunmagwarehouse.com/kel-tec-pf9-9mm-7-round-magazine.html
Mag surface area: https://imgur.com/a/FgLnS5r
Kel-Tec P32, OAL 12.9cm and width 1.9cm: https://www.keltecweapons.com/firearms/pistols/p32/
Surface area: https://imgur.com/a/oV2CF8L
Mag floorplate length for scaling: https://imgur.com/a/bJFRf2w
Flat view of mag: https://gunmagwarehouse.com/kel-tec-p32-32-acp-7-round-magazine.html
Mag SA: https://imgur.com/a/6WX3PO6
Kel-Tec P3AT, OAL 13.2cm and width 2.0cm: https://www.keltecweapons.com/firearms/pistols/p3at/
SA: https://imgur.com/a/bEWbAIY
Mag floorplate: https://imgur.com/a/tshHOKY
Flat view of mag: https://www.cheaperthandirt.com/kel-tec-p-3at-6-round-magazine-.380-acp-steel-blued-finish/FC-640832002041.html
Mag SA: https://imgur.com/a/YyEiG1k