Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aftershock modern json #39040

Merged
merged 4 commits into from
Mar 27, 2020
Merged

Aftershock modern json #39040

merged 4 commits into from
Mar 27, 2020

Conversation

snipercup
Copy link
Contributor

Summary

SUMMARY: none

Purpose of change

Contributes to #36110

Describe the solution

  • Change name to object
  • Volume to string
  • fix looks_like: It referred to an abstract item but that is pointless. I checked that no tileset has any sprite for the abstract it referred to and then changed it to the same bionic item id I used in Add looks like to positive bionic cbm items #35202
  • Changed the 'mode' called 'default' from '1rd' to 'single' in afs_eidolon_derringer to be more in line with the vanilla guns. This is only visual.
  • The file 5x50.json did have valid json but I added a [ in front and ] after the object definition to be more in line with the rest of the files.

Describe alternatives you've considered

Not changing

Testing

I was unable to spawn broken_chickenbot and I can't explain why
image
image
image

@ZhilkinSerg ZhilkinSerg added the [JSON] Changes (can be) made in JSON label Mar 26, 2020
@ZhilkinSerg ZhilkinSerg merged commit b7966ea into CleverRaven:master Mar 27, 2020
@snipercup snipercup deleted the Aftershock-name-to-object branch March 27, 2020 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants