Generalize solarpack code #38770
Merged
Generalize solarpack code #38770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymber
added
[JSON]
BevapDin
reviewed
Mar 14, 2020
BevapDin
reviewed
Mar 14, 2020
BevapDin
reviewed
Mar 14, 2020
|
Moved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Generalize solarpack code"
Purpose of change
Allow new items to be defined without engine changes.
Describe the solution
Remove hardcoded item IDs from the code and define solar panel efficiency in JSON.
Testing
Items behave as before in game. No user facing changes.