vehicle_part name to object #38699
Merged
vehicle_part name to object #38699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMurkin
reviewed
Mar 11, 2020
| @@ -2,7 +2,7 @@ | |||
| { | |||
| "id": "aisle_lights", | |||
| "type": "vehicle_part", | |||
| "name": "aisle lights", | |||
| "name": { "str": "aisle lights" }, | |||
There was a problem hiding this comment.
lights and harness should have plural forms. Or not?
ZhilkinSerg
reviewed
Mar 11, 2020
| @@ -220,7 +220,7 @@ | |||
| { | |||
| "id": "lit_aisle_horizontal", | |||
| "type": "vehicle_part", | |||
| "name": "aisle with lights", | |||
| "name": { "str": "aisle with lights" }, | |||
There was a problem hiding this comment.
Suggested change
| "name": { "str": "aisle with lights" }, | |
| "name": { "str": "aisle with lights", "str_pl": "aisles with lights" }, |
ZhilkinSerg
reviewed
Mar 11, 2020
| @@ -2,7 +2,7 @@ | |||
| { | |||
| "id": "aisle_lights", | |||
| "type": "vehicle_part", | |||
| "name": "aisle lights", | |||
| "name": { "str": "aisle lights" }, | |||
There was a problem hiding this comment.
Suggested change
| "name": { "str": "aisle lights" }, | |
| "name": { "str": "aisle lights", "str_pl": "aisle lights" }, |
ZhilkinSerg
reviewed
Mar 11, 2020
| @@ -1851,7 +1851,7 @@ | |||
| { | |||
| "type": "vehicle_part", | |||
| "id": "seatbelt_heavyduty", | |||
| "name": "5-point harness", | |||
| "name": { "str": "5-point harness" }, | |||
There was a problem hiding this comment.
Suggested change
| "name": { "str": "5-point harness" }, | |
| "name": { "str": "5-point harness", "str_pl": "5-point harnesses" }, |
ZhilkinSerg
reviewed
Mar 11, 2020
| @@ -2263,7 +2263,7 @@ | |||
| { | |||
| "type": "vehicle_part", | |||
| "id": "craft_rig", | |||
| "name": "FOODCO kitchen buddy", | |||
| "name": { "str": "FOODCO kitchen buddy" }, | |||
There was a problem hiding this comment.
Suggested change
| "name": { "str": "FOODCO kitchen buddy" }, | |
| "name": { "str": "FOODCO kitchen buddy", "str_pl": "FOODCO kitchen buddies" }, |
|
Cannot add plurals am afraid: This pr should be merged as-is unless there is a typo I missed |
|
Sorry for the confusion. It just looks unusual. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: nonePurpose of change
Contributes to #36110 and #36611
Describe the solution
Change name to object
Describe alternatives you've considered
Not changing
Testing