Airgun nerf & air cylinders #38654
Airgun nerf & air cylinders #38654
Conversation
ZhilkinSerg
added
0.E Content Freeze
[JSON]
Co-Authored-By: Anton Burmistrov <Night_Pryanik@mail.ru>
…erprimus/Cataclysm-DDA into airgun-nerf-&-air-cylinders
|
Isn't this PR now invalid since the weapons are going to be obsoleted(#39438)? |
Possibly. I have no idea what his criteria for obsoleting items is other than that he decided he doesn't want something, so therefore it goes away. This PR was supposed to be a temporary measure that made the pneumatic weapons a lot less ridiculous and more realistic, while still providing for the ability to make these weapons until a more comprehensive change occurs to weapon parts. In reality you'd make a DIY weapon out of parts from a damaged existing weapon and the same would apply to repairing firearms (you would find compatible intact parts and replace them until you have one functional gun), which is IMO even more ridiculous currently in DDA. My gun fouling PR was partly designed to remedy this by unabstracting gun wear by separating fouling and damage. Modern guns are machined or stamped in a factory. You can't just "fix" an M16A4's bent parts (which are forged to act like clockwork) with a magical DIY "firearm repair kit." However I'm not aware of any such PR being in the works as it would require big changes like keeping track of the condition of individual parts of an item and having those parts contribute to the functioning of the item in component-specific ways. I'd say that's a long way off if it ever arrives. I suppose if I had to choose between making something like the pneumatic pebble rifle nonexistent or as is, I'd choose nonexistent, but as this PR suggests it's not a binary choice like that with some intermediate solutions available. |
|
That PR is removing the pneumatic weapons that are videogame references and have no resemblance to something that exists. A PR adding pneumatic weapons that bear actual resemblance to or model something that exists is fine. |
|
Though caveat to that, a new pneumatic weapon that fires pebbles is likewise not going to be ok, it needs to fire a functional ammunition like lead shot or steel bearings. |
This one would fire pellets that have to be made from metal, not pebbles. |
|
This pull request introduces 1 alert when merging 5d189f0 into f7d6b59 - view on LGTM.com new alerts:
|
| @@ -1944,6 +1945,9 @@ void player::process_items() | |||
| if( ch_UPS_used > 0 ) { | |||
| use_charges( "UPS", ch_UPS_used ); | |||
| } | |||
| if( ch_AIR_used > 0 ) { | |||
There was a problem hiding this comment.
It believes that this condition will never be true.
There was a problem hiding this comment.
ch_AIR_used is initialized to zero and never changed, so this comparison can never be true.
|
Do the devs want these changes? Just wondering since I heard they were going in their own direction with compressed air weapons and this thing has been open for 2 months. If the devs don't want this, then there's no point in fixing that error, as simple as the fix may be (not sure if I'm going to get merge conflicts, though, this being so old). |
|
This isn't a correct approach. |
How to use
Spawn the pneumatic air rifle & some pellets and experiment firing it.
Summary
SUMMARY: Balance "Makes air guns realistic."Purpose of change
#38196
The purpose is to make air guns more realistic by adding an air component to them. Currently flamethrowers just "work" and the air rifle abstracts the reloading process of the air (in addition to using impossible "pebbles" for ammo). This maintains these parameters separately and uses appropriate ammunition.
Describe the solution
Mainly changes the air rifle to be like something you'd be able to buy online and adds compressed air as an item.
Describe alternatives you've considered
#38498
Testing
Just JSON changes here. I tested the pumping mechanics in a different PR. One day I suspect those will be usable with precharged pneumatics once multimags is done.
Additional context