Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Portuguese (Brazil) to language selection menu #38424

Merged
merged 1 commit into from
Mar 2, 2020

Conversation

ZhilkinSerg
Copy link
Contributor

@ZhilkinSerg ZhilkinSerg commented Feb 28, 2020

Summary

SUMMARY: I18N "Add Portuguese (Brazil) to language selection menu"

Purpose of change

Portuguese (Brazil) translation is on par with Polish, Korean and both Spanish translations now, so we may re-allow its explicit selection through options menu.

image

Describe the solution

Add Portuguese (Brazil) to language selection menu.

Describe alternatives you've considered

It is possible to select in-game language automatically using system language, but it is less reliable and does not work in all systems.

Testing

See that language appears in option menu and strings are translated when it is selected.

Additional context

There is apparently an issue with some extended Latin characters missing from Terminus font - we need to address it in another PR.

@ZhilkinSerg ZhilkinSerg added Translation I18n [C++] Changes (can be) made in C++. Previously named `Code` labels Feb 28, 2020
@kevingranade kevingranade merged commit d510b67 into master Mar 2, 2020
@ZhilkinSerg ZhilkinSerg deleted the language-portuguese-brazil branch March 2, 2020 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Translation I18n
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants