Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More centralized string reverts #38421

Merged

Conversation

kevingranade
Copy link
Member

Summary

SUMMARY: None

Purpose of change

Continues to revert additions to src/cata_string_consts.h

Describe the solution

Revert more.

Describe alternatives you've considered

The next commit is really gross to untangle, I think there were a lot of unrelated commits that my somewhat simplistic "commits that touched cata_string_consts.h" search missed, so from here on the revert needs to be manual.

Testing

Builds and nothing immediate blows up.

@ZhilkinSerg ZhilkinSerg added [C++] Changes (can be) made in C++. Previously named `Code` Code: Build Issues regarding different builds and build environments labels Feb 28, 2020
@ZhilkinSerg ZhilkinSerg merged commit d9dbfbe into CleverRaven:master Feb 28, 2020
fengjixuchui added a commit to fengjixuchui/Cataclysm-DDA that referenced this pull request Feb 28, 2020
@kevingranade kevingranade deleted the more-centralized-string-reverts branch June 28, 2020 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Code: Build Issues regarding different builds and build environments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants