Disable -Wredundant-decls in CMake on Windows build #38402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad nanosleep if present
ZhilkinSerg
added
Code: Build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
This check was causing compilation errors on MinGW-w64 on Windows, and was failing even in system headers.
Describe the solution
Fixed the first error reported, i.e. redundant declaration of
nanosleep. It now skips the custom definition if it's using winpthread. The next error was about some built-in function being a redundant declaration of a function inintrin.h, and does not seem to be fixable on our end, so the warning itself was suppressed instead.Testing
Game compiles.