Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gunmod name to object, volume to string #38377

Merged
merged 1 commit into from
Feb 26, 2020
Merged

Gunmod name to object, volume to string #38377

merged 1 commit into from
Feb 26, 2020

Conversation

snipercup
Copy link
Contributor

@snipercup snipercup commented Feb 26, 2020

Summary

SUMMARY: Balance "Shoulder strap adds volume when attaching it to a weapon"

Purpose of change

Contributes to #36110 and #36611

Describe the solution

Change name to object
Change volume to string. I only added volume to the ones where I was sure it makes sense. The other ones I don't know enough about or the description explicitly states it only adds weight.

Describe alternatives you've considered

Not changing

Testing

image
image
image

@ZhilkinSerg ZhilkinSerg added the [JSON] Changes (can be) made in JSON label Feb 26, 2020
@ZhilkinSerg ZhilkinSerg merged commit cc27d10 into CleverRaven:master Feb 26, 2020
@snipercup snipercup deleted the Gunmod-modern-json branch February 26, 2020 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants