Remove "not possessive" context #38365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I guess you mean the ternary operator |
`xgettext` can only extract the first string when using ternary operator. Considering that the "not possessive" context was introduced in CleverRaven#27482 and it is not ambiguous now. We can remove this context for better extraction.
|
Oh yes. Thanks for point out that. |
ZhilkinSerg
added
[C++]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
xgettextcan only extract the first string when using the ternary operator.Considering that the "not possessive" context was introduced in #27482
and it is not ambiguous now. We can remove this context for better
extraction.
Describe the solution
Remove "not possessive" context
Describe alternatives you've considered
Expand the ternary operator into if-else.
Testing
Run
lang/update_pot.shand check if both "You" and "you" is inlang/po/cataclysm-dda.pot.Additional context