Explicitly instantiate conditional_t

[kevingranade]

Summary

SUMMARY: None

Purpose of change

Build time profiling (see https://gist.github.com/ralreegorganon/b8211f6a286b880108ddad810aba76e3#file-gistfile1-txt-L159) points to conditional.cpp compile times being extremely high. It looks like the templating of conditional_t is the culprit.

Describe the solution

Switching conditional_t to explicit instantiation to reduce compile times.

Testing

If it builds it should work.

Additional context

See https://en.cppreference.com/w/cpp/language/class_template for explanation of explicit instantiation.

[ZhilkinSerg]

Breaks cross-compile to OSX on Jenkins, but don't affect native OSX builds as Travis CI passed.

https://ci.narc.ro/job/Cataclysm-Matrix/Graphics=Tiles,Platform=OSX/10370/consoleFull

13:36:14 Undefined symbols for architecture x86_64:
13:36:14   "conditional_t<dialogue>::conditional_t()", referenced from:
13:36:14       dynamic_line_t::dynamic_line_t(JsonObject const&) in npctalk.o
13:36:14 ld: symbol(s) not found for architecture x86_64
13:36:14 clang: error: linker command failed with exit code 1 (use -v to see invocation)
13:36:14 Makefile:828: recipe for target 'cataclysm-tiles' failed
13:36:14 make: *** [cataclysm-tiles] Error 1
13:36:14 make: *** Waiting for unfinished jobs....

[ZhilkinSerg]

Could be related:

https://stackoverflow.com/questions/19821041/g-ld-symbols-not-found-for-architecture-x86-64
https://stackoverflow.com/questions/19637164/c-linking-error-after-upgrading-to-mac-os-x-10-9-xcode-5-0-1
https://stackoverflow.com/questions/12770115/linking-libraries-opencv-2-4-2-on-xcode-4-5-1

---

Edit: Using different standard lib did not help. It actually stopped to compile at all (see https://ci.narc.ro/job/Cataclysm-Matrix/10374/Graphics=Curses,Platform=OSX/console).

[kevingranade]

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/compiling-error/22951/3

[kevingranade]

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/compiling-error/22951/4