Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify "Gather 75 Stones" quest messages #38329

Merged
merged 2 commits into from
Feb 25, 2020

Conversation

jkraybill
Copy link
Contributor

@jkraybill jkraybill commented Feb 25, 2020

Summary

SUMMARY: Content "Clarify 'Gather 75 Stones' quest messages"

Purpose of change

Fixes #38328.

To make it clearer that this request requires 75 rocks.

Describe the solution

Changed some of the terms from "stones" to "rocks".

Describe alternatives you've considered

Not changing it. The existing messages were confusing to me; they seemed to be alluding to a material larger than a rock but smaller than a boulder, and I spent a little bit of time trying to figure out if this existed before diving into the JSON, so I decided this was better than doing nothing.

Testing

Re-loaded after JSON change, verified quest menu.

image

@curstwist
Copy link
Contributor

The Isherwoods also have a collect stones quest, would you go ahead and include it in your fix?

@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Missions Quests and missions labels Feb 25, 2020
@ZhilkinSerg ZhilkinSerg merged commit dea003e into CleverRaven:master Feb 25, 2020
@jkraybill jkraybill deleted the 38328 branch March 1, 2020 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Missions Quests and missions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Gather 75 Stones" quest should be called "Gather 75 Rocks"
3 participants