Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim player include #38324

Merged
merged 2 commits into from
Feb 25, 2020
Merged

Conversation

kevingranade
Copy link
Member

Summary

SUMMARY: None

Purpose of change

Analysis has shown that some large header files, foremost among them player.h are contributing a great deal to build times.

Describe the solution

Trim unnecessary player.h includes from other header files.

Testing

It builds!

@ZhilkinSerg ZhilkinSerg added [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style labels Feb 25, 2020
@ZhilkinSerg ZhilkinSerg merged commit 983ed6c into CleverRaven:master Feb 25, 2020
@kevingranade kevingranade deleted the trim-player-include branch February 25, 2020 17:11
@kevingranade kevingranade restored the trim-player-include branch February 25, 2020 17:11
@kevingranade kevingranade deleted the trim-player-include branch February 25, 2020 17:11
@kevingranade kevingranade restored the trim-player-include branch February 25, 2020 17:13
@kevingranade kevingranade deleted the trim-player-include branch February 25, 2020 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants