Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 3l jar a by-product of heavy cream from milk cream jar recipe #38316

Merged
merged 1 commit into from
Feb 25, 2020

Conversation

CSHague
Copy link
Contributor

@CSHague CSHague commented Feb 25, 2020

Previously, using this recipe, the 3L jar will simply disappear.

Summary

SUMMARY: Bugfixes "Add 3L jar as by-product of heavy cream recipe"

Purpose of change

Intended to fix a bug discovered in this recipe. Specifically, this recipe uses a sealed jar of milk cream as an ingredient. When completing the recipe you get 5 units of heavy cream and 7 units of buttermilk. However the 3L jar used to make the milk cream jar is lost in hammer-space. This PR fixes that.

Describe the solution

Add the 3L jar as a by-product of the heavy cream recipe. Placement in the by-product array is irrelevant as the jar always results last when tested.

Describe alternatives you've considered

None really. This seemed the most obvious fix.

Testing

image

Resulting buttermilk was stored in a separate 3L jar but the by-product jar did come as a result.

Previously, using this recipe, the 3L jar will simply disappear.
@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling labels Feb 25, 2020
@ZhilkinSerg ZhilkinSerg merged commit 7e64112 into CleverRaven:master Feb 25, 2020
@CSHague CSHague deleted the patch-7 branch February 25, 2020 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants