Pass CLI arguments from cataclysm-launcher shell script to cataclysm binary #38139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifreund
added
<Enhancement / Feature>
|
..and I screwed this up. Was accidentally testing |
damien
force-pushed
the
pass-launcher-cli-flags-to-bin
branch
from
c47fd34 to
eab11a2
Compare
|
Fixed, for realities this time. Shell scripting is lame. |
|
EDIT: This was already mostly done in #38742 Actually, I think what you really want is: exec "./$BIN" "$@"That should properly maintain correct quoting (especially for things with spaces in them). |
|
@geophree Feel free to open up a new PR if you'd like to follow up on this. In practice I don't think it'll be an issue until somebody tries to pass stuff to the binary that can be misquoted, which I suspect is rare since I seem to have been the first person to stumble up on this so far. 🤷♂ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Pass CLI arguments from cataclysm-launcher shell script to cataclysm binary"Purpose of change
Enable
cataclysm-launchersh script to pass command line arguments to the bundled C:DDA binary.Describe the solution
Include arguments in the
execinvocation.Describe alternatives you've considered
Leaving this as is.
Testing
Tested using Unbuntu under WSL. No problems. Ubuntu uses Dash for it's
shprocessor, but as far as I'm aware it's POSIX compliant and this change should work across all POSIX-compliantshinterpreters.Additional context
Found this while I was exploring CLI options for the C:DDA binary.