Auto-travel; prompt when overburdened, and allow stamina-resting #38113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifreund
added
<Bugfix>
ZhilkinSerg
reviewed
Feb 18, 2020
Co-Authored-By: Anton Burmistrov <Night_Pryanik@mail.ru>
Co-Authored-By: Anton Burmistrov <Night_Pryanik@mail.ru>
Co-Authored-By: Anton Burmistrov <Night_Pryanik@mail.ru>
…taclysm-DDA into tired_travelling
BevapDin
reviewed
Feb 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Auto-travel; prompt when overburdened, and allow stamina-resting"Purpose of change
Fixes #37785
Describe the solution
Prompt when starting autotravel, if player is overburdened, if the yare sure they want to.
Also, fix the fact that the travelling activity, never stopped to catch breath like other activities did.
This was made harder by the fact that the travellign activity, every do_turn() call, nulled itself, and the stamina did not drop as a result of its do_turn(), it dropped afterwards, when the player pathed their automove route, I did something which is perhaps a bit inelegant? and simulated a small drop in stamina after travel do_turn(), so that it passed the stamina < previous_stamina test in player_activity.cpp
Describe alternatives you've considered
N/A
Testing
Picked u pan XL wind turbine, used autotravel, I got the prompt, and if I said yes, then the player moved but paused to catch breath every second or so, so stamina didnt drain completely.
Additional context
N/A