Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move string consts out of several files #38107

Merged
merged 2 commits into from
Feb 17, 2020

Conversation

Ramza13
Copy link
Contributor

@Ramza13 Ramza13 commented Feb 17, 2020

Summary

SUMMARY: Infrastructure "Move string consts into cata_string_consts.h from several files"

Purpose of change

Centralize string consts in one location for good coding practice.

Describe the solution

Describe alternatives you've considered

Testing

Additional context

@ZhilkinSerg ZhilkinSerg added [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style labels Feb 17, 2020
@ZhilkinSerg ZhilkinSerg merged commit ab283d9 into CleverRaven:master Feb 17, 2020
@Ramza13 Ramza13 deleted the string_consts_few branch February 17, 2020 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants