item groups sort part 8 #38094
Merged
item groups sort part 8 #38094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
created 2 new .jsons -- vehicles_fuel_related and furniture. Moved various item groups from item_groups.json to relevant .jsons. Moved nighstand from mansion to collection_domestic.
ZhilkinSerg
added
[JSON]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "created new categorical .jsons and migrated various lists from item_groups.json"Purpose of change
tidying
Describe the solution
created 2 new .jsons -- vehicles_fuel_related and furniture. Moved various item groups from item_groups.json to relevant .jsons. Moved nightstand from mansion to collection_domestic, as I think it's a useful list and needs more love.
Describe alternatives you've considered
Testing
linted and debug spawned lists in-game.
Additional context
My goal is to completely do away with item_groups.json. Any item list that doesn't fit into a categorical list will just end up in the misc file.