-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Magiclysm: summon vehicle spell : floating disk #37991
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! i've been wanting this feature for a long time. I haven't loaded it up yet, so here's just the stuff i noticed while reading through the code.
What happens to vehicle parts that the player installs manually to the magic vehicle? What happens if the player removes part from the magic vehicle (do they despawn)? What happens to parts that are broken of from the vehicle? |
They can't interact with the vehicle, when it is a magic vehicle, they dont get a chance to open the interaction menu to remove or install parts. The parts themselves do not |
just thought of this: the spell needs a scroll, and to be put into an item group. i'm thinking the tier 2 spell scroll itemgroup should be good. |
This might be true for your example vehicle, but it's not true in the general case. I can change the |
The magic flag is added when the vehicle is summoned, no matter what the vehicle is. in the spell function. EDIT: ah, yeah it wont be interactable, thta checks the vehicle-wide magic flag, but its parts could still drop bits and pieces, cos the parts themselves arent magical. Hmm ill add a check for if( vehicle->magic ) before dropping parts |
Added check for if vehicle is magic - then dont allow parts to be broken off or deposit anything on the ground. And added scroll for the spell, and added it to item groups. |
ad63e77
to
8e68539
Compare
621a68e
to
b7106d0
Compare
0f30a43
to
d432807
Compare
Rebased, cleaned up, retested, working. |
The json and magiclysm vehicle looks good. |
Summary
SUMMARY: Content "Magiclysm: summon vehicle spell : floating disk"
Purpose of change
Adds a technomancer spell to summon a floating disk to carry cargo.
any spell can now be defined with a vproto_id string, this spell type is summon_vehicle, and it will summon the defined vehicle, for the defined amount of time, after which it will dissappear.
Magic vehicles are not interactable, so they cant be refuelled / repaired etc.
( I plan to add a magic carpet type thing after this, by which point it may be that ill need to add handling for how to interact with the vehicle refill it with 'mana' fuel etc - that can come later, this is just the proof of concept of summoning a vehicle )
Describe the solution
New spell effect, new vehicle type - floating disk, add summon effect, spawn vehicle, mark it as magic, give it a summon timer, as per the summon monster spells.
Open the (C)hat menu to order it to follow you around, or you can drag it.
Describe alternatives you've considered
N/A
Testing
cast the spell, summoned the vehicle, ordered it to follow me, placed items in it, walked around, it followed, when the spell ran out, the vehicle was destroyed, and the items inside it fell out.
Additional context
The JSON stuff - the spell stats, the descriptions, the levels, everything are just placeholders right now, just to showcase the feature @KorGgenT I'm sure will show me how they want it, I have no idea how to balance it for that.