-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate/obsolete incongruent Leadworks, EBR, and Rivtech guns #37979
Conversation
I do really want to bring Rivtech back with some other items. We should look into having them on item description snippets and things |
I haven't removed any Rivtech guns in their caseless families. |
Ah good |
21c82fe
to
f529a5d
Compare
f529a5d
to
cd816a6
Compare
The items that no longer exist are still on blacklists in mods, and need to be removed, because it's causing the tests to fail. |
I have those fixes locally, I think I'll push this and then push my fixes afterwards. |
Removes the guns that were removed as per CleverRaven#37979 - to note, tavor_12 was migrated in item but not ID to avoid save compatibility, but is now rectified.
Removes the guns that were removed as per CleverRaven#37979 - to note, tavor_12 was migrated in item but not ID to avoid save compatibility, but is now rectified.
Removes the guns that were removed as per CleverRaven#37979 - to note, tavor_12 was migrated in item but not ID to avoid save compatibility, but is now rectified.
Summary
SUMMARY: Content "migrates+obsoletes firearms incongruent with lore"
Purpose of change
Leadworks largely takes a leaf from the XM8 program, which sought to integrate modularity into a service rifle, but not at a user level. The rifles, and other similar built-in-mod guns have not seen success in real life as they are purported to have done so in-game.
The RM360 describes an entirely fictional .22 LR gatling gun, which would be available to SOT's only. Seeing as it is mostly a range toy, I doubt a serious company would build such a thing and market it.
The Mosin EBR kits have been obsoleted by the mounting furniture gunmods.
Describe the solution
Obsoletes or migrates items in question. Redefines LW-Feed, obsoleted, to work with Stanags instead of migrated items. Backup revolver is obsoleted, to either be later migrated to an AR pistol or a single-shot 223 PAR-1.
460 guns migrated to a .460 1911, magazines altered to accept them.
Describe alternatives you've considered
Obsoleting .460 guns and adding 1911 later.
That whole leadworks western gun company I was suggesting, but that's still a lot of mental gymnastics.
Pretending that the XM8 was actually successful.
Testing
Loaded mainline. Loaded generic guns. Checked to make sure everything still migrated correctly. Figuring out how to handle migration/blacklisting in GG was a bit of a bear, but I managed.
![premigration](https://user-images.githubusercontent.com/7764202/74382972-f39f2780-4db3-11ea-806e-4df49418859f.PNG)
![postmigration](https://user-images.githubusercontent.com/7764202/74382975-f437be00-4db3-11ea-96af-e9796fb2d662.PNG)
Additional context
Generic guns has a potential load error- I have accidently re-used the abstract item ID
pistol_revolver
for the generic gunspolice revolver
. Fix to come.