Add houses for existing basements #37902
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Content "Adds 5 houses for existing basements."
Purpose of change
Covers basements: meth (3 for 1 house), chem (2 in 2 houses), survival, weed
Describe the solution
It was easier to add houses then reshape these to existing floor plans. I'll add empty variants later.
These basements didn't have the "NO_ROTATE" tag in overmap_terrains and all went under the generic "basement" ID. They did have entries in the mapgen for
"rotate": [ 0, 3]
which I removed. Please let me know if additional work needs to be done for migration.Describe alternatives you've considered
These will need empty variants so I can weight their spawns since they are pretty specialized. Those can be added later though.
Testing
Spawned in world.
Additional context
house 26:
![house26](https://user-images.githubusercontent.com/39442864/74194114-a477bc00-4c26-11ea-8bd6-1b7891bdcd1d.PNG)
![house26 roof](https://user-images.githubusercontent.com/39442864/74194115-a5105280-4c26-11ea-823e-04f378317342.PNG)
house27:
![house27](https://user-images.githubusercontent.com/39442864/74194129-ad688d80-4c26-11ea-9c0d-8899135779ff.PNG)
![house27 roof](https://user-images.githubusercontent.com/39442864/74194131-ae012400-4c26-11ea-8476-db095afe06fb.PNG)
house28:
![house28](https://user-images.githubusercontent.com/39442864/74194142-b48f9b80-4c26-11ea-904e-df81e3c3da42.PNG)
![house28 roof](https://user-images.githubusercontent.com/39442864/74194144-b5283200-4c26-11ea-8afc-e8f3ed3a4a4f.PNG)
house29:
![house29](https://user-images.githubusercontent.com/39442864/74194158-bb1e1300-4c26-11ea-8e33-03987b55da95.PNG)
![house29 roof](https://user-images.githubusercontent.com/39442864/74194159-bb1e1300-4c26-11ea-8308-ff5e1de233d0.PNG)
house30:
![house30](https://user-images.githubusercontent.com/39442864/74194168-c07b5d80-4c26-11ea-958c-8522d2e58fe3.PNG)
![house30roof](https://user-images.githubusercontent.com/39442864/74194169-c113f400-4c26-11ea-98c8-1167e7891ee3.PNG)