Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add houses for existing basements #37902

Merged
merged 2 commits into from
Feb 11, 2020

Conversation

curstwist
Copy link
Contributor

Summary

SUMMARY: Content "Adds 5 houses for existing basements."

Purpose of change

Covers basements: meth (3 for 1 house), chem (2 in 2 houses), survival, weed

Describe the solution

It was easier to add houses then reshape these to existing floor plans. I'll add empty variants later.

These basements didn't have the "NO_ROTATE" tag in overmap_terrains and all went under the generic "basement" ID. They did have entries in the mapgen for "rotate": [ 0, 3] which I removed. Please let me know if additional work needs to be done for migration.

Describe alternatives you've considered

These will need empty variants so I can weight their spawns since they are pretty specialized. Those can be added later though.

Testing

Spawned in world.

Additional context

house 26:
house26
house26 roof

house27:
house27
house27 roof

house28:
house28
house28 roof

house29:
house29
house29 roof

house30:
house30
house30roof

@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display labels Feb 11, 2020
@I-am-Erk
Copy link
Member

So many houses!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants