Improve submap encapsulation #37893
Merged
Improve submap encapsulation #37893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are still two loose ends on proper encapsulation here. Namely, the non-const get_field() and get_items(). These need to be replaced with either the necessary setters or by moving necessary code to submap.
ifreund
added
[C++]
BevapDin
reviewed
Feb 10, 2020
This was referenced Feb 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Improve submap encapsulation"
Purpose of change
Further progress towards #29674
Describe the solution
Add additional getter/setter functions to
submapand make the inheritance frommaptile_soaprivate.This does not yet achieve complete encapsulation as
get_field()andget_items()have non-const versions allowing free access tofldanditm. However, this PR does successfully encapsulate the rest of the members ofmaptile_soaand sets the stage for followup PRs completing the encapsulation offldanditm.There should be no observable differences in game due to these changes.
Testing
Compiled and ran the tests. Loaded in to a game without issues.