Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing string_format call #37831

Merged
merged 3 commits into from
Feb 8, 2020
Merged

Conversation

ifreund
Copy link
Contributor

@ifreund ifreund commented Feb 8, 2020

Summary

SUMMARY: None

Purpose of change

Compiling the master branch currently triggers warnings due to a missing string_format call.

Describe the solution

Fix the syntax

Testing

Compiles without warnings

@ifreund ifreund added Code: Build Issues regarding different builds and build environments <Bugfix> This is a fix for a bug (or closes open issue) labels Feb 8, 2020
src/character.cpp Outdated Show resolved Hide resolved
@BevapDin
Copy link
Contributor

BevapDin commented Feb 8, 2020

You probably don't even need the explicit call to string_format as ret_val::make_failure does it anyway.

@ifreund
Copy link
Contributor Author

ifreund commented Feb 8, 2020

So it does @BevapDin. Thanks.

@ZhilkinSerg ZhilkinSerg merged commit f8f5817 into CleverRaven:master Feb 8, 2020
@ifreund ifreund deleted the fix-compile branch February 8, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) Code: Build Issues regarding different builds and build environments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants