Clean some bionic activation code #37813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
[C++]
This was referenced Feb 9, 2020
Huh, they're both plural in code but not in json
it's not connected to a power source
olanti-p
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Clean some cases in bionic activation code"Purpose of change
Bionic activation messages are sometimes weird or misleading (e.g. #33663). Failure to activate a bionic sometimes returns as a success or consumes power when it shouldn't. This is an effort to fix the majority of these issues
Describe the solution
I went through all paths and made sure
You activate your CBMmessage displayed only when it makes sense; the power spent is properly returned on failure / if bionic is not used; bionic turned off if it fails to activate andfalseis returned.Describe alternatives you've considered
Leaving it as is until the bionic overhaul
Testing
It compiles, gives the player some message(s) on all paths and shouldn't break external code because no one except NPCs cares about returned value, and none of the bionics I changed are usable by NPCs.