Always prompt for direction if autoselect disabled #37805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the current behavior and the AUTOSELECT_SINGLE_VALID_TARGET option disabled, there is inconsistency in the behavior of pressing c to close or e to examine. This can cause unintended actions if attempted on an invalid target. For example, if standing next to an already closed door and one quickly presses `c`lose and then the direction of the door, the first keypress will have no effect as the closed door is not a valid target. The second keypress will then open the door, which is the opposite of the intent. This commit removes the failure message and subsequent abortion of the action in the case that there is no valid target as to improve consistency.
ifreund
added
Info / User Interface
This was referenced Feb 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Always prompt for direction if autoselect disabled"
Purpose of change
With the current behavior and the AUTOSELECT_SINGLE_VALID_TARGET option
disabled, there is inconsistency in the behavior of pressing c to close
or e to examine. This can cause unintended actions if attempted on an
invalid target.
For example, if standing next to an already closed door and one
quickly presses
close and then the direction of the door, the firstkeypress will have no effect as the closed door is not a valid target.
The second keypress will then open the door, which is the opposite of
the intent.
Describe the solution
This commit removes the failure message and subsequent abortion of the
action in the case that there is no valid target as to improve consistency.
Testing
Option works as per the intent of this commit in game.
Additional context
Closes #37745, though isn't directly in response to that.