Converting multi-cooker to another item when it is filled with a dish. #37794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To prevent other crafting processes to touch it when it is cooking.
ZhilkinSerg
added
<Bugfix>
ZhilkinSerg
reviewed
Feb 7, 2020
data/json/items/tool/cooking.json
Outdated
| "copy-from": "multi_cooker", | ||
| "name": { "str": "multi cooker - cooking" }, | ||
| "description": "A professional-grade multi-cooker, with a battery slot for camping trips or tailgating. There is a dish in it.", | ||
| "//": "Don't know how to force it to lose qualities. Specifying empty array here seems not to work.", |
There was a problem hiding this comment.
You can put full item definition instead of using copy-from.
Or try something like:
"delete": { "qualities": [ [ "COOK", 3 ] ] },
"extend": { "qualities": [ [ "HAMMER", 1 ], [ "COOK", 2 ] ] }There was a problem hiding this comment.
"delete": { "qualities": [ [ "COOK", 3 ] ] },
Did not worked for qualities.
I made full item definition instead.
There was a problem hiding this comment.
@ZhilkinSerg 's PR is landed, so you can redo this on top of his new feature.
This was referenced Feb 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Multicooker disapear from inventory when crafting other things"Purpose of change
Fixes #37728 - Multicooker disapear from inventory when crafting other things
Describe the solution
Convert multi cooker to another item when it is filled with dish. This prevents other code from messing with It's qualities when trying to perform parallel crafting. Also it makes sense because multi-cooker cannot be used to heat other things when it is filled with a dish.
Describe alternatives you've considered
Modify crafting handling code to find where things go south when trying to use activated multi-cooker as a tool. Actually, in my opinion, investigation of the cause of such strange behaviour of item disapearing and calling function that shouldn't be called there should be done no matter if this PR will be merged or not.
Testing
Spawned a multi-cooker, tried to craft a dish with it. Tried to craft another dish manually while multi cooker was active.
Additional context
N/A