Migrate ammotypes of guns, magazines, and mods #37746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifreund
added
Items: Magazines
ifreund
force-pushed
the
ammo-migration-fix
branch
from
b6ed82d to
d1d1881
Compare
|
Realized that I forgot to leave a comment earlier today when I finished this. It now migrates magazine type compatibility as well as ammo type compatibility. The game loads without error with and without generic guns enabled. I failed to find anything amiss in game, the crash from the wish menu and dysfunctional magiclysm gunblade are both fixed. This ended up requiring a few json bugfixes as well which this new code brought to light. |
I-am-Erk
pushed a commit
that referenced
this pull request
Feb 9, 2020
* Fix Magiclysm guns showing with Generic Guns active * Revert gunblade migration in favor of #37746
This was referenced Feb 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Migrate ammotypes of guns, magazines, and mods."
Purpose of change
Right now ammotype compatibility is not migrated properly. This can be demonstrated by creating a world with generic guns and wishing for a mark 19 grenade launcher, which crashes the game.
Describe the solution
Essentially migrate ammotype compatibility and default ammo.
Testing
Wishing for a mark 19 grenade launcher now works. The gunblade from magiclysm is now compatible with generic guns as well.
Additional context
This isn't 100% finished yet, it still triggers a handful of "magazine does not take compatible ammo" errors on load which I haven't been able to track down yet.