Gun volume audit for .270 Win + a typo #37719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
[JSON]
ghost
deleted the
This was referenced Feb 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Content "Realistic gun volume for .270 Winchester"Purpose of change
Helps #37374. Also, there was a typo in its description.
Describe the solution
Gun volume as surface area times width.
Describe alternatives you've considered
Doing shadow scaling based on Remington's image and the barrel width.
Bundling this with another caliber audit since it's just one gun. Decided against it for consistency.
Testing
Loaded ingame.
Additional context
Remington 700 CDL SF in .270 Win, total length 44.5": https://www.remington.com/rifles/bolt-action/model-700/model-700-cdl-sf
Width of 1.35" obtained from blueprint on Practical Machinist on making action(thanks Tonk ❤️): https://www.practicalmachinist.com/vb/gunsmithing/making-remington-700-action-179971/index5.html
Coloring in for Binarization: https://imgur.com/a/JCoYfkP
SA Results: https://imgur.com/a/J8U4vNg