Updated new Taekwondo techniques to be style specific #37680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
<Bugfix>
|
Got it, didn't know they were supposed to be unique to each style! Thanks |
I'm working on a best practices guide to help contributers. It should help explain the do's and don'ts and game balance concepts when dealing with the martial arts system. |
This was referenced Feb 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Updated new Taekwondo techniques to be style specific"Purpose of change
Created two new techniques for Taekwondo instead of using the techniques from other styles.
Describe the solution
In regards to #37362, I've updated the techniques added to the Taekwondo style to be unique to Taekwondo. It is bad practice to use techniques or buffs designed for one martial arts style in a second martial arts style because if the technique or buff is modified or removed to balance one style, the second style is also effected. This is why so many styles have techniques that are identical. Leaving the techniques as is can cause unwanted bugs and additional work for content creators in the future.