Generic Guns: Bandoliers and bugfixes #37666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 2, 2020 23:23
tenmillimaster
added
<Bugfix>
This was referenced Feb 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Mods "Reworks bandoliers for Generic Guns"Purpose of change
Rocket launchers weren't defined correctly, causing bugs.
There was an ordinal JSON load error, where the m249 CROWS would spawn as its DDA incarnation instead of its GG redefinition.
Secubot UGV's couldn't shoot their rifles.
Bandoliers were completely unconsidered, and could not stow any ammunition.
Some of the descriptions needed improving (and some spelling mistakes). Some names were incorrect.
Describe the solution
Adds correct ammo type to the rocket launchers.
Switches position of m240 and m249 CROWS turret redefinitions.
Changes ammo types on bandoliers.
Sets UGV default ammo correctly.
Updates and corrects various descriptions and names.
Describe alternatives you've considered
None.
Testing
Spawned all the turrets and UGV's and let them have a go at me.
Spawned all the bandoliers to check for correct ammo types.
Spawned rocket launchers and shot them.