Martial arts text updates #37095
Merged
Martial arts text updates #37095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Further changes
|
There is an extra % in the text descriptions to escape the other %. If you leave it as a single %, the game assumes that it is trying to do string formatting and will completely screw up the text. |
|
It does? I thought that might be the case but from observing the text afterwards it appeared to render fine:
Regardless, if that is the case I'll drop those changes % changes and just stick with the rest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Interface "Updates Martial Art Descriptions for Accuracy"Purpose of change
Strange additional "%"s everywhere for no discernible reason (except for one spot), some descriptions were inaccurate to what the effect actually did.
Describe the solution
Change the text to be accurate to the effect and conform to the style standards of other descriptions in the MA JSON file, remove additional "%"s
Describe alternatives you've considered
Leave it inaccurate
Testing
Debugged all martial arts, checked through descriptions to make sure things didn't look odd, punched nearby NPC a couple times for the conditional effect descriptions. Didn't go through all of them, however, as this was only description changes so I don't foresee anything major.