Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop auto sort from visiting empty vehicle tiles #36889

Merged
merged 1 commit into from
Jan 10, 2020

Conversation

Qrox
Copy link
Contributor

@Qrox Qrox commented Jan 10, 2020

Summary

SUMMARY: Bugfixes "Stop auto sort from visiting empty vehicle tiles"

Purpose of change

Previously when the player starts auto sort near a vehicle, all of the vehicle's cargo tiles will be visited regardless of whether the tiles contain items. This can cause unnecessary movement over the cargo tiles, which slows down auto sort, especially when the vehicle has many cargo tiles.

Describe the solution

Check if a vehicle part contains items before pathing to that part.

Testing

Started auto sort near a truck with only a few cargo tiles containing items. Only those tiles containing items were visited during auto sort.

@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Inventory / AIM / Zones Inventory, Advanced Inventory Management or Zones Vehicles Vehicles, parts, mechanics & interactions labels Jan 10, 2020
@ZhilkinSerg ZhilkinSerg merged commit 857e244 into CleverRaven:master Jan 10, 2020
@Qrox Qrox deleted the auto-sort-veh branch January 11, 2020 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Inventory / AIM / Zones Inventory, Advanced Inventory Management or Zones Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants